removing function Attributes from the AST tree#1276
Merged
Conversation
…onAttribute`, `FunctionTypeAttribute`, `ModifierAttribute`, `ReceiveFunctionAttribute`, `StateVariableAttribute`, and `UnnamedFunctionAttribute` from the AST tree
Janther
commented
Oct 1, 2025
Comment on lines
+66
to
+77
| Exclude< | ||
| StrictAstNode, | ||
| | ArgumentsDeclaration | ||
| | ConstructorAttribute | ||
| | FallbackFunctionAttribute | ||
| | FunctionAttribute | ||
| | FunctionTypeAttribute | ||
| | ModifierAttribute | ||
| | ReceiveFunctionAttribute | ||
| | StateVariableAttribute | ||
| | UnnamedFunctionAttribute | ||
| > |
Member
Author
There was a problem hiding this comment.
this is the only section that for now looks a bit ugly to me, but it gets removed in the last step, for now we need to name every PolymorphicNode that we have successfully removed from the AST tree.
fvictorio
reviewed
Oct 8, 2025
| // comment 5 | ||
| modifier2(/* comment 7 */) // comment 6 // comment 8 | ||
| modifier2(/* comment 7 */) // comment 6 | ||
| // comment 8 |
Member
There was a problem hiding this comment.
This seems like a mistake, doesn't it?
Member
There was a problem hiding this comment.
Ah, no, sorry, I saw the unformatted code that corresponds to this result. Makes sense.
fvictorio
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing with extracting variants from PolymorphicNodes.
In this PR
We address the following nodes
ConstructorAttributeFallbackFunctionAttributeFunctionAttributeFunctionTypeAttributeModifierAttributeReceiveFunctionAttributeStateVariableAttributeUnnamedFunctionAttributeOn top of that, in every collection of these attributes we remove the
printVariantas we don't need it anymore and instead of having 2 map functions chained, we just have 1 map to avoid looping twice.We are also removing multiple destructuring of the
variantattribute of these attributes.Caveat
There was one test scenario that had to be fixed because before one comment would be associated to the
PolymorphicNodeand another to thevariant, and now both of these comments are associated to the same node.